fix: await mac signing before notarization - #72
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a macOS release race by switching the Electron mac signing hook to the Promise-based @electron/osx-sign API so notarization can’t start before nested code signing completes, and it advances all release/version surfaces to v0.1.27 after the v0.1.26 artifact publication failure.
Changes:
- Switch macOS signing to
signAsyncand route electron-builder signing through an awaitable signer. - Add a regression test asserting the signer is awaitable.
- Bump versions/release references to
0.1.27across docs, packages, site/web/mobile/desktop surfaces, and release-consistency tests.
Reviewed changes
Copilot reviewed 27 out of 27 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| SECURITY.md | Updates macOS release version reference to v0.1.27. |
| scripts/sign-macos.mjs | Uses Promise-based signAsync and exports macSigner for awaitability. |
| scripts/packaging.test.mjs | Adds regression test ensuring macOS signer returns a thenable. |
| scripts/check-release-consistency.test.mjs | Updates release drift guards to v0.1.27. |
| README.md | Updates download links and “what changed” section to v0.1.27. |
| packages/ui/package.json | Bumps package version to 0.1.27. |
| packages/service-manager/package.json | Bumps package version to 0.1.27. |
| packages/remote/package.json | Bumps package version to 0.1.27. |
| packages/protocol/test/fixtures/platform-boundaries.ts | Updates protocol fixtures to latestVersion 0.1.27. |
| packages/protocol/package.json | Bumps package version to 0.1.27. |
| packages/fixture-server/package.json | Bumps package version to 0.1.27. |
| packages/client/src/omp-client-frames.ts | Updates default client hello version to 0.1.27. |
| packages/client/package.json | Bumps package version to 0.1.27. |
| package.json | Bumps workspace root version to 0.1.27. |
| e2e/site-mobile-docs.spec.ts | Updates expected Android download URL to v0.1.27. |
| docs/CURRENT_RELEASE_NOTES.md | Updates release notes to v0.1.27 and explains v0.1.26 artifact absence. |
| compat/omp-app-matrix.json | Updates desktop protocol version mapping to 0.1.27. |
| apps/web/src/platform/browser-shell-port.ts | Updates reported client version to 0.1.27. |
| apps/web/package.json | Bumps app version to 0.1.27. |
| apps/site/test/release.test.ts | Updates release asset contract assertions to v0.1.27. |
| apps/site/src/release.ts | Updates release tag/version and asset filenames to v0.1.27. |
| apps/site/package.json | Bumps app version to 0.1.27. |
| apps/mobile/package.json | Bumps app version to 0.1.27. |
| apps/mobile/capacitor.config.json | Updates appended user agent version to 0.1.27. |
| apps/desktop/src/target-manager.ts | Updates desktop client metadata version to 0.1.27. |
| apps/desktop/package.json | Bumps app version to 0.1.27. |
| .github/ISSUE_TEMPLATE/bug_report.yml | Updates bug report version placeholder to 0.1.27. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
Fix the Mac release race exposed by v0.1.26 and prepare v0.1.27.
Verification